Messages in this thread | | | Date | Fri, 23 Jun 2017 00:01:21 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH] NFC: trf7970a: fix check of clock frequencies, use && instead of || |
| |
Hi Colin,
On Mon, Apr 24, 2017 at 02:36:02PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The "or" condition (clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) || > (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUE) will always be true because > clk_freq cannot be equal to two different values at the same time. Use > the && operator instead of || to fix this. > > Detected by CoverityScan, CID#1430468 ("Constant expression result") > > Fixes: 837eb4d21ecde7 ("NFC: trf7970a: add device tree option for 27MHz clock") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/nfc/trf7970a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to nfc-next, thanks.
Cheers, Samuel.
| |