lkml.org 
[lkml]   [2017]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Wednesday, June 21, 2017 6:17 PM
> To: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; KY Srinivasan <kys@microsoft.com>;
> Haiyang Zhang <haiyangz@microsoft.com>; David S. Miller
> <davem@davemloft.net>; Simon Xiao <sixiao@microsoft.com>;
> devel@linuxdriverproject.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] netvsc: don't access netdev->num_rx_queues directly
>=20
> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
>=20
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has
> no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh':
> drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has
> no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
>=20
> As the value is only set once to the argument of alloc_netdev_mq(),
> we can compare against that constant directly.
>=20
> Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
> Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of
> channels")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>

Thanks.

\
 
 \ /
  Last update: 2017-06-22 20:00    [W:0.021 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site