lkml.org 
[lkml]   [2017]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static
On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer ilb_base_addr does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'ilb_base_addr' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks Colin.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 506e62ca3576..c915d65c1909 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev)
> #define LPC_CNTRL_REG_OFFSET 0x84
> #define LPC_CLKRUN_EN (1 << 2)
>
> -void __iomem *ilb_base_addr;
> +static void __iomem *ilb_base_addr;
>
> static inline bool is_bsw(void)
> {
> --
> 2.11.0
>

\
 
 \ /
  Last update: 2017-06-20 17:07    [W:0.169 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site