Messages in this thread | | | Date | Fri, 2 Jun 2017 10:24:17 -0700 | From | Eric Biggers <> | Subject | Re: [PATCH 1/5] KEYS: sanitize add_key() and keyctl() key payloads |
| |
On Fri, Jun 02, 2017 at 04:34:44PM +0100, David Howells wrote: > Eric Biggers <ebiggers3@gmail.com> wrote: > > > error2: > > + memzero_explicit(payload, plen); > > Isn't that wrong? payload can be NULL. > > David
If you're talking about memset(NULL, ..., 0) being undefined behavior, it's completely insane but sure, I guess we should add the NULL check to be safe. It would also mean there would be no requirement that "KEYS: fix dereferencing NULL payload with nonzero length" be applied first so the second paragraph of the commit message would be removed. I'll send a v2 of just this patch.
Eric
| |