lkml.org 
[lkml]   [2017]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 176/268] cpmac: remove hopeless #warning
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit d43e6fb4ac4abfe4ef7c102833ed02330ad701e0 upstream.

    The #warning was present 10 years ago when the driver first got merged.
    As the platform is rather obsolete by now, it seems very unlikely that
    the warning will cause anyone to fix the code properly.

    kernelci.org reports the warning for every build in the meantime, so
    I think it's better to just turn it into a code comment to reduce
    noise.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/net/ethernet/ti/cpmac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
    index 6bcb2b8..922f7dd 100644
    --- a/drivers/net/ethernet/ti/cpmac.c
    +++ b/drivers/net/ethernet/ti/cpmac.c
    @@ -1242,7 +1242,7 @@ int cpmac_init(void)
    goto fail_alloc;
    }

    -#warning FIXME: unhardcode gpio&reset bits
    + /* FIXME: unhardcode gpio&reset bits */
    ar7_gpio_disable(26);
    ar7_gpio_disable(27);
    ar7_device_reset(AR7_RESET_BIT_CPMAC_LO);
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-19 20:51    [W:4.291 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site