lkml.org 
[lkml]   [2017]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 23/60] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tony Lindgren <tony@atomide.com>

    commit 8b8a84c54aff4256d592dc18346c65ecf6811b45 upstream.

    Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
    added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
    bit the wrong way. The comments in the code are correct, but the inverted
    use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
    enabled instead of disabled unlike what the comments say.

    Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
    be only pinged few times before it stops responding.

    Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Acked-by: Roger Quadros <rogerq@ti.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mfd/omap-usb-tll.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mfd/omap-usb-tll.c
    +++ b/drivers/mfd/omap-usb-tll.c
    @@ -377,8 +377,8 @@ int omap_tll_init(struct usbhs_omap_plat
    * and use SDR Mode
    */
    reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
    - | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
    | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
    + reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
    } else if (pdata->port_mode[i] ==
    OMAP_EHCI_PORT_MODE_HSIC) {
    /*

    \
     
     \ /
      Last update: 2017-06-19 17:57    [W:4.226 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site