lkml.org 
[lkml]   [2017]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 42/60] drivers/misc/c2port/c2port-duramar2150.c: checking for NULL instead of IS_ERR()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 8128a31eaadbcdfa37774bbd28f3f00bac69996a upstream.

    c2port_device_register() never returns NULL, it uses error pointers.

    Link: http://lkml.kernel.org/r/20170412083321.GC3250@mwanda
    Fixes: 65131cd52b9e ("c2port: add c2port support for Eurotech Duramar 2150")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Rodolfo Giometti <giometti@linux.it>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/misc/c2port/c2port-duramar2150.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/misc/c2port/c2port-duramar2150.c
    +++ b/drivers/misc/c2port/c2port-duramar2150.c
    @@ -129,8 +129,8 @@ static int __init duramar2150_c2port_ini

    duramar2150_c2port_dev = c2port_device_register("uc",
    &duramar2150_c2port_ops, NULL);
    - if (!duramar2150_c2port_dev) {
    - ret = -ENODEV;
    + if (IS_ERR(duramar2150_c2port_dev)) {
    + ret = PTR_ERR(duramar2150_c2port_dev);
    goto free_region;
    }


    \
     
     \ /
      Last update: 2017-06-19 17:31    [W:4.071 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site