Messages in this thread | | | Date | Mon, 19 Jun 2017 06:39:21 +0100 | From | Okash Khawaja <> | Subject | Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t |
| |
On Mon, Jun 19, 2017 at 09:15:33AM +0800, Greg Kroah-Hartman wrote: > > +int ser_to_dev(int ser, dev_t *dev_no) > > +{ > > + if (ser < 0 || ser > (255 - 64)) { > > + pr_err("speakup: Invalid ser param. \ > > + Must be between 0 and 191 inclusive.\n"); > > As Andy pointed out, never do this for a C string, it's not doing what > you think it is :) Of course! I am sorry I should address such issues before submitting. Will watch out more carefully next time.
> > Worse case, do this like the following: > pr_err("speakup: Invalid ser param." > "Must be between 0 and 191 inclusive.\n"); > > Also note, you are using spaces here in the patch, always run > checkpatch.pl on your patches, so you don't get a grumpy maintainer > telling you to run checkpatch.pl on your patches :) Sure.
Thanks for the patience.
Okash
| |