lkml.org 
[lkml]   [2017]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm: exynos: hdmi: make of_device_ids const.
From
Date
On 19.06.2017 11:24, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 12294 1192 0 13486 34ae drivers/gpu/drm/exynos/exynos_hdmi.o
>
> File size after constify hdmi_match_types.
> text data bss dec hex filename
> 13318 176 0 13494 34b6 drivers/gpu/drm/exynos/exynos_hdmi.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

--
Regards
Andrzej

> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 1ff6ab6..624c48d 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1683,7 +1683,7 @@ static int hdmi_resources_init(struct hdmi_context *hdata)
> return hdmi_bridge_init(hdata);
> }
>
> -static struct of_device_id hdmi_match_types[] = {
> +static const struct of_device_id hdmi_match_types[] = {
> {
> .compatible = "samsung,exynos4210-hdmi",
> .data = &exynos4210_hdmi_driver_data,


\
 
 \ /
  Last update: 2017-06-19 12:12    [W:0.038 / U:36.284 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site