lkml.org 
[lkml]   [2017]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 066/268] scsi: avoid a permanent stop of the scsi device's request queue
    Date
    From: Wei Fang <fangwei1@huawei.com>

    commit d2a145252c52792bc59e4767b486b26c430af4bb upstream.

    A race between scanning and fc_remote_port_delete() may result in a
    permanent stop if the device gets blocked before scsi_sysfs_add_sdev()
    and unblocked after. The reason is that blocking a device sets both the
    SDEV_BLOCKED state and the QUEUE_FLAG_STOPPED. However,
    scsi_sysfs_add_sdev() unconditionally sets SDEV_RUNNING which causes the
    device to be ignored by scsi_target_unblock() and thus never have its
    QUEUE_FLAG_STOPPED cleared leading to a device which is apparently
    running but has a stopped queue.

    We actually have two places where SDEV_RUNNING is set: once in
    scsi_add_lun() which respects the blocked flag and once in
    scsi_sysfs_add_sdev() which doesn't. Since the second set is entirely
    spurious, simply remove it to fix the problem.

    Reported-by: Zengxi Chen <chenzengxi@huawei.com>
    Signed-off-by: Wei Fang <fangwei1@huawei.com>
    Reviewed-by: Ewan D. Milne <emilne@redhat.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/scsi/scsi_sysfs.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
    index 135d7b5..53da653 100644
    --- a/drivers/scsi/scsi_sysfs.c
    +++ b/drivers/scsi/scsi_sysfs.c
    @@ -865,10 +865,6 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
    struct request_queue *rq = sdev->request_queue;
    struct scsi_target *starget = sdev->sdev_target;

    - error = scsi_device_set_state(sdev, SDEV_RUNNING);
    - if (error)
    - return error;
    -
    error = scsi_target_add(starget);
    if (error)
    return error;
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-19 21:40    [W:2.313 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site