lkml.org 
[lkml]   [2017]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 254/268] sctp: listen on the sock only when it's state is listening or closed
    Date
    From: Xin Long <lucien.xin@gmail.com>

    commit 34b2789f1d9bf8dcca9b5cb553d076ca2cd898ee upstream.

    Now sctp doesn't check sock's state before listening on it. It could
    even cause changing a sock with any state to become a listening sock
    when doing sctp_listen.

    This patch is to fix it by checking sock's state in sctp_listen, so
    that it will listen on the sock with right state.

    Reported-by: Andrey Konovalov <andreyknvl@google.com>
    Tested-by: Andrey Konovalov <andreyknvl@google.com>
    Signed-off-by: Xin Long <lucien.xin@gmail.com>
    Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    net/sctp/socket.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/net/sctp/socket.c b/net/sctp/socket.c
    index 4178cf3..4358ae8 100644
    --- a/net/sctp/socket.c
    +++ b/net/sctp/socket.c
    @@ -6181,6 +6181,9 @@ int sctp_inet_listen(struct socket *sock, int backlog)
    if (sock->state != SS_UNCONNECTED)
    goto out;

    + if (!sctp_sstate(sk, LISTENING) && !sctp_sstate(sk, CLOSED))
    + goto out;
    +
    /* If backlog is zero, disable listening. */
    if (!backlog) {
    if (sctp_sstate(sk, CLOSED))
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-19 21:31    [W:4.317 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site