lkml.org 
[lkml]   [2017]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Documentation: clock: address more for clock-cells property
On Wed, Jun 14, 2017 at 06:11:37PM +0800, Chunyan Zhang wrote:
> Hi Geert,
>
> On 14 June 2017 at 17:42, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > Hi Chunyan,
> >
> > On Wed, Jun 14, 2017 at 11:21 AM, Chunyan Zhang
> > <zhang.chunyan@linaro.org> wrote:
> >> The value of property 'clock-cells' is not determined only by the number
> >> of clock outputs in one clock node, it is determined by whether the clock
> >> output in this node can be referenced directly without index. If the
> >> output clock has to be referenced by a index, the clock-cell of this
> >> clock node can't be defined 0.
> >>
> >> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> >> ---
> >> Documentation/devicetree/bindings/clock/clock-bindings.txt | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
> >> index 2ec489e..e2b76b4 100644
> >> --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
> >> +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
> >> @@ -18,6 +18,9 @@ Required properties:
> >> with a single clock output and 1 for nodes with multiple
> >> clock outputs.
> >>
> >> + There's one exception, please see the description for
> >> + clock-indices below.
> >> +
> >> Optional properties:
> >> clock-output-names: Recommended to be a list of strings of clock output signal
> >> names indexed by the first cell in the clock specifier.
> >> @@ -48,6 +51,13 @@ clock-indices: If the identifying number for the clocks in the node
> >> is not linear from zero, then this allows the mapping of
> >> identifiers into the clock-output-names array.
> >>
> >> + This property not only servers for clocks with multiple
> >
> > serves
>
> Thanks, I will fix that.
>
> >
> >> + clock outputs, but also for clocks with a single clock
> >> + output whose identifying number is not zero.
> >
> > Why would you want a single clock and a non-zero identifying number?
>
> Because of the probably weird hardwire design :)
> There indeed some clocks like that on the platform I'm working on.

But still, why do you care what the ID# is?

Rob

\
 
 \ /
  Last update: 2017-06-18 16:07    [W:0.251 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site