lkml.org 
[lkml]   [2017]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 1/3] kbuild: Add __cc-option macro
    Hi Matthias,


    Sorry, the code I suggested introduced a slight behavior change.

    With this patch, cc-option adds a space before the returned option.


    Please see line 46 of arch/sh/Makefile.

    ifeq ($(cflags-y),)


    Now cflags-y contains a space, so
    this conditional is now evaluated as false,
    which was actually true without the patch.
    This is the cause of the build error.


    Could you remove whitespaces before $(1) and $(2) in cc-option?

    Also, please fix hostcc-option as well.

    Thanks!






    2017-06-18 15:58 GMT+09:00 kbuild test robot <lkp@intel.com>:
    > Hi Matthias,
    >
    > [auto build test ERROR on tip/auto-latest]
    > [also build test ERROR on v4.12-rc5 next-20170616]
    > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
    >
    > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/kbuild-Add-__cc-option-macro/20170616-082252
    > config: sh-sh7710voipgw_defconfig (attached as .config)
    > compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
    > reproduce:
    > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    > chmod +x ~/bin/make.cross
    > # save the attached .config to linux build tree
    > make.cross ARCH=sh
    >
    > All errors (new ones prefixed by >>):
    >
    > {standard input}: Assembler messages:
    >>> {standard input}:672: Error: invalid operands for opcode
    > {standard input}:673: Error: opcode not valid for this cpu variant
    > {standard input}:674: Error: opcode not valid for this cpu variant
    > {standard input}:675: Error: invalid operands for opcode
    > {standard input}:1900: Error: invalid operands for opcode
    > {standard input}:1901: Error: opcode not valid for this cpu variant
    > {standard input}:1902: Error: opcode not valid for this cpu variant
    > {standard input}:1903: Error: invalid operands for opcode
    > {standard input}:2067: Error: invalid operands for opcode
    > {standard input}:2068: Error: opcode not valid for this cpu variant
    > {standard input}:2069: Error: opcode not valid for this cpu variant
    > {standard input}:2070: Error: invalid operands for opcode
    > {standard input}:2570: Error: invalid operands for opcode
    > {standard input}:2571: Error: opcode not valid for this cpu variant
    > {standard input}:2572: Error: opcode not valid for this cpu variant
    > {standard input}:2573: Error: invalid operands for opcode
    >
    > ---
    > 0-DAY kernel test infrastructure Open Source Technology Center
    > https://lists.01.org/pipermail/kbuild-all Intel Corporation



    --
    Best Regards
    Masahiro Yamada

    \
     
     \ /
      Last update: 2017-06-19 04:01    [W:3.308 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site