lkml.org 
[lkml]   [2017]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card.
On Sat, Jun 17, 2017 at 4:02 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> From: Alexander Gerasiov <gq@redlab-i.ru>
>
> WCH CH382L is a PCI-E adapter with 1 parallel port. It is similair to CH382
> but serial ports are not soldered on board. Detected as
> Serial controller: Device 1c00:3050 (rev 10) (prog-if 05 [16850])

> wch_ch382_2s1p,
> + wch_ch382_0s1p,

> /* wch_ch382_2s1p*/ { 1, { { 2, -1}, } },
> + /* wch_ch382_0s1p*/ { 1, { { 2, -1}, } },

> { 0x1c00, 0x3250, 0x1c00, 0x3250, 0, 0, wch_ch382_2s1p},
> + { 0x1c00, 0x3050, 0x1c00, 0x3050, 0, 0, wch_ch382_0s1p},

Just a nit, wouldn't be better to preserve alphanumerical sorting?
(Exchange lines in above pairs)

> + [wch_ch382_0s1p] = {
...
> [sunix_2s1p] = {

Similar here, though it's not visible in the patch.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-06-17 15:46    [W:0.068 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site