Messages in this thread | | | Date | Sat, 17 Jun 2017 05:57:55 -0400 | From | Theodore Ts'o <> | Subject | Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem context [ver #5] |
| |
On Wed, Jun 14, 2017 at 01:53:09PM -0700, Casey Schaufler wrote: > On 6/14/2017 1:42 PM, David Howells wrote: > > Casey Schaufler <casey@schaufler-ca.com> wrote: > > > >> Could you namespace the fields of this structure? > >> e.g. fs_cred, fs_security > > Linus objects to that practice. > > Sigh. Never mind. Thank you.
I don't know that this is a hard and fast rule. Struct bio uses a "bi_" prefix (e.g., bi_error, bi_opf, bi_iter, etc.).
I find it's really helpful when I'm doing a "git grep" over the whole tree; "git grep bi_flags" returns a much more specific and focused results than "git grep flags". :-)
- Ted
| |