lkml.org 
[lkml]   [2017]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO
On Fri, 16 Jun 2017, Florian Fainelli wrote:

> > How did you determine that? Malta for one not only has an SMSC FDC37M817
> > Super I/O Controller featuring an 8042-compatible core, but actual PS/2
> > keyboard and mouse connectors as well.
>
> I was just grepping for i8042 in platform code to determine that, this
> came after having SERIO accidentally enabled on my platform
> (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap
> out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that
> don't need it.
>
> Will come up with a v2 that includes malta, any other platforms for
> which it's not obvious?

I don't know offhand, but in principle anything that has PCI and a
southbridge (not all PCI platforms have one, e.g. Broadcom SWARM and
BigSur are legacy-free) can have an 8042 wired. Ideally probing for 8042
hardware should be done by platform code and the driver's init code would
not be called at all if there's no 8042 present, similarly to how e.g. RTC
is usually registered.

Maciej

\
 
 \ /
  Last update: 2017-06-16 22:19    [W:0.066 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site