Messages in this thread | | | Date | Fri, 16 Jun 2017 13:27:23 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array |
| |
Em Fri, Jun 16, 2017 at 11:23:39AM -0500, Kim Phillips escreveu: > These defines were probably dragged in from sampling support in earlier > patches. They can be put back when needed.
Applied.
Ah, please capitalize the first word after the : in the summary, i.e.:
[PATCH 1/2 v2] perf intel-pt/bts: Remove unused SAMPLE_SIZE
Thanks,
- Arnaldo
> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > Signed-off-by: Kim Phillips <kim.phillips@arm.com> > --- > v2: addressed Ingo's comment by populating changelog with Adrian's > explanation of why they were unused > > tools/perf/arch/x86/util/intel-bts.c | 4 ---- > tools/perf/arch/x86/util/intel-pt.c | 4 ---- > tools/perf/util/intel-bts.c | 2 -- > 3 files changed, 10 deletions(-) > > diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c > index af2bce7a2cd6..781df40b2966 100644 > --- a/tools/perf/arch/x86/util/intel-bts.c > +++ b/tools/perf/arch/x86/util/intel-bts.c > @@ -35,10 +35,6 @@ > #define KiB_MASK(x) (KiB(x) - 1) > #define MiB_MASK(x) (MiB(x) - 1) > > -#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4) > - > -#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60) > - > struct intel_bts_snapshot_ref { > void *ref_buf; > size_t ref_offset; > diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c > index f630de0206a1..6fe667b3269e 100644 > --- a/tools/perf/arch/x86/util/intel-pt.c > +++ b/tools/perf/arch/x86/util/intel-pt.c > @@ -40,10 +40,6 @@ > #define KiB_MASK(x) (KiB(x) - 1) > #define MiB_MASK(x) (MiB(x) - 1) > > -#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4) > - > -#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60) > - > #define INTEL_PT_PSB_PERIOD_NEAR 256 > > struct intel_pt_snapshot_ref { > diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c > index b2834ac7b1f5..218ee2bac9a5 100644 > --- a/tools/perf/util/intel-bts.c > +++ b/tools/perf/util/intel-bts.c > @@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish) > fprintf(stdout, intel_bts_info_fmts[i], arr[i]); > } > > -u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE]; > - > int intel_bts_process_auxtrace_info(union perf_event *event, > struct perf_session *session) > { > -- > 2.11.0
| |