lkml.org 
[lkml]   [2017]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus layer
    From
    Date
    Hi Rafal,

    On Friday 16 June 2017 11:41 AM, Rafał Miłecki wrote:
    > On 16 June 2017 at 08:04, Kishon Vijay Abraham I <kishon@ti.com> wrote:
    >> On Thursday 11 May 2017 09:59 PM, Florian Fainelli wrote:
    >>> On 05/11/2017 06:29 AM, Rafał Miłecki wrote:
    >>>> @@ -297,6 +371,28 @@ static struct platform_driver bcm_ns_usb3_driver = {
    >>>> .of_match_table = bcm_ns_usb3_id_table,
    >>>> },
    >>>> };
    >>>> -module_platform_driver(bcm_ns_usb3_driver);
    >>>> +
    >>>> +static int __init bcm_ns_usb3_module_init(void)
    >>>> +{
    >>>> + int err;
    >>>> +
    >>>> + err = mdio_driver_register(&bcm_ns_usb3_mdio_driver);
    >>>> + if (err)
    >>>> + return err;
    >>>> +
    >>>> + err = platform_driver_register(&bcm_ns_usb3_driver);
    >>>> + if (err)
    >>>> + mdio_driver_unregister(&bcm_ns_usb3_mdio_driver);
    >>>> +
    >>>> + return err;
    >>>> +}
    >>>> +module_init(bcm_ns_usb3_module_init);
    >>>> +
    >>>> +static void __exit bcm_ns_usb3_module_exit(void)
    >>>> +{
    >>>> + platform_driver_unregister(&bcm_ns_usb3_driver);
    >>>> + mdio_driver_unregister(&bcm_ns_usb3_mdio_driver);
    >>>> +}
    >>>> +module_exit(bcm_ns_usb3_module_exit)
    >>>
    >>> Do we need to keep both platform device and mdio device registration
    >>> here? Do you have a depreciation time line for when we can entirely
    >>> switch to mdio device (assuming this is for backwards compatibility)?
    >>
    >> I too have the same question.
    >
    > My plan is to:
    > 1) Get this patch accepted
    > 2) Switch DTS files to use the new binding
    > 3) Maybe wait for LTS release if we care that much
    > 4) Drop old binding support

    old dt's are generally not allowed to break. So I'm not sure if we shoud ever
    drop old binding support. Rest sounds good.

    Thanks
    Kishon

    \
     
     \ /
      Last update: 2017-06-16 08:32    [W:3.930 / U:0.964 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site