Messages in this thread | | | Date | Fri, 16 Jun 2017 10:18:56 +0100 | From | Mark Brown <> | Subject | Re: Applied "ASoC: rockchip: Fix an error handling in 'rockchip_i2s_probe'" to the asoc tree |
| |
On Fri, Jun 16, 2017 at 06:57:30AM +0200, Christophe JAILLET wrote: > Le 15/06/2017 à 19:20, Mark Brown a écrit :
> > if (!of_property_read_u32(node, "rockchip,playback-channels", &val)) { > > if (val >= 2 && val <= 8) > > soc_dai->playback.channels_max = val;
> ... and 'err' should be 'ret'...
> I'm really confused for such a ugly proposal !
In a situation like this it's generally best to send a patch, I'll fix though. [unhandled content-type:application/pgp-signature] | |