lkml.org 
[lkml]   [2017]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 005/108] ibmvnic: Fix endian errors in error reporting output
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>


    [ Upstream commit 75224c93fa985f4a6fb983f53208f5c5aa555fbf ]

    Error reports received from firmware were not being converted from
    big endian values, leading to bogus error codes reported on little
    endian systems.

    Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/ibm/ibmvnic.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/net/ethernet/ibm/ibmvnic.c
    +++ b/drivers/net/ethernet/ibm/ibmvnic.c
    @@ -2197,12 +2197,12 @@ static void handle_error_info_rsp(union

    if (!found) {
    dev_err(dev, "Couldn't find error id %x\n",
    - crq->request_error_rsp.error_id);
    + be32_to_cpu(crq->request_error_rsp.error_id));
    return;
    }

    dev_err(dev, "Detailed info for error id %x:",
    - crq->request_error_rsp.error_id);
    + be32_to_cpu(crq->request_error_rsp.error_id));

    for (i = 0; i < error_buff->len; i++) {
    pr_cont("%02x", (int)error_buff->buff[i]);
    @@ -2281,8 +2281,8 @@ static void handle_error_indication(unio
    dev_err(dev, "Firmware reports %serror id %x, cause %d\n",
    crq->error_indication.
    flags & IBMVNIC_FATAL_ERROR ? "FATAL " : "",
    - crq->error_indication.error_id,
    - crq->error_indication.error_cause);
    + be32_to_cpu(crq->error_indication.error_id),
    + be16_to_cpu(crq->error_indication.error_cause));

    error_buff = kmalloc(sizeof(*error_buff), GFP_ATOMIC);
    if (!error_buff)

    \
     
     \ /
      Last update: 2017-06-15 20:23    [W:4.121 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site