Messages in this thread | | | Date | Thu, 15 Jun 2017 08:14:31 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] objtool: Add fortify_panic as __noreturn function |
| |
On Wed, Jun 14, 2017 at 07:18:51PM -0700, Kees Cook wrote: > CONFIG_FORTIFY_SOURCE implements fortify_panic() as a __noreturn function, > so objtool needs to know about it too. > > Suggested-by: Daniel Micay <danielmicay@gmail.com> > Signed-off-by: Kees Cook <keescook@chromium.org> > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > --- > tools/objtool/builtin-check.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c > index 282a60368b14..5f66697fe1e0 100644 > --- a/tools/objtool/builtin-check.c > +++ b/tools/objtool/builtin-check.c > @@ -192,7 +192,8 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func, > "complete_and_exit", > "kvm_spurious_fault", > "__reiserfs_panic", > - "lbug_with_loc" > + "lbug_with_loc", > + "fortify_panic", > }; > > if (func->bind == STB_WEAK)
Thanks, I'll take the patch.
Eventually I'd like to experiment with a GCC plugin to automatically detect these noreturn cases instead of the hard-coded list.
-- Josh
| |