lkml.org 
[lkml]   [2017]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/12] coresight tmc: Expose DBA and AXICTL
    On Mon, Jun 12, 2017 at 03:36:45PM +0100, Suzuki K Poulose wrote:
    > Expose DBALO,DBAHI and AXICTL registers

    Why is this needed? I fear we are exposing internal kernel information.

    >
    > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    > ---
    > drivers/hwtracing/coresight/coresight-tmc.c | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
    > index 7025982..fd5a2e0 100644
    > --- a/drivers/hwtracing/coresight/coresight-tmc.c
    > +++ b/drivers/hwtracing/coresight/coresight-tmc.c
    > @@ -228,9 +228,11 @@ coresight_tmc_simple_func(ffcr, TMC_FFCR);
    > coresight_tmc_simple_func(mode, TMC_MODE);
    > coresight_tmc_simple_func(pscr, TMC_PSCR);
    > coresight_tmc_simple_func(devid, CORESIGHT_DEVID);
    > +coresight_tmc_simple_func(axictl, TMC_AXICTL);
    >
    > coresight_simple_reg64(struct tmc_drvdata, rrp, TMC_RRP, TMC_RRPHI);
    > coresight_simple_reg64(struct tmc_drvdata, rwp, TMC_RWP, TMC_RWPHI);
    > +coresight_simple_reg64(struct tmc_drvdata, dba, TMC_DBALO, TMC_DBAHI);
    >
    > static struct attribute *coresight_tmc_mgmt_attrs[] = {
    > &dev_attr_rsz.attr,
    > @@ -244,6 +246,8 @@ static struct attribute *coresight_tmc_mgmt_attrs[] = {
    > &dev_attr_mode.attr,
    > &dev_attr_pscr.attr,
    > &dev_attr_devid.attr,
    > + &dev_attr_dba.attr,
    > + &dev_attr_axictl.attr,
    > NULL,
    > };
    >
    > --
    > 2.7.4
    >

    \
     
     \ /
      Last update: 2017-06-14 19:51    [W:4.977 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site