lkml.org 
[lkml]   [2017]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support
On Fri, Jun 09, 2017 at 03:10:36PM +0800, Mark Yao wrote:
> RK3399 and RK3288 shared the same HDMI IP controller, only some light
> difference with GRF configure.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> Changes in v3:
> remove hdmi_phy_configure_dwc_hdmi_3d_tx callbak.
>
> Changes in v2:
> reuse hdmi_phy_configure_dwc_hdmi_3d_tx for phy configure
> fixup Documentation
>
> .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 3 +-
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 67 ++++++++++++++++++----
> 2 files changed, 58 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> index 046076c..495bcf5 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> @@ -11,7 +11,8 @@ following device-specific properties.
>
> Required properties:
>
> -- compatible: Shall contain "rockchip,rk3288-dw-hdmi".
> +- compatible: "rockchip,rk3288-dw-hdmi",
> + "rockchip,rk3399-dw-hdmi";

Is this supposed to be "one of" or both? Please format it as 1 valid
combination per line. Drop the ',' and the ';' because I see that as dts
syntax.

> - reg: See dw_hdmi.txt.
> - reg-io-width: See dw_hdmi.txt. Shall be 4.
> - interrupts: HDMI interrupt number

\
 
 \ /
  Last update: 2017-06-14 17:33    [W:0.068 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site