lkml.org 
[lkml]   [2017]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/8] tty: add a poll() callback in struct tty_operations
    > That would cut it, but TIOCPKT is too coupled with having a linked tty.
    > I could make acm behave like a pty (accept TIOCPKT and issue the
    > ctrl_status bits), but for that I need n_tty to know that packet does
    > not always mean a linked tty is present, and that in case it isn't we
    > take our own ctrl_status bits instead of the link's. I could write a
    > small (inline?) function to fetch the correct ctrl_status bits and put
    > that in n_tty. Does that make sense?

    I think that makes sense, and I would do the job properly rather than do
    a hack with tty->link. Those hacks in the long term never work out the
    best approach.

    Alan

    \
     
     \ /
      Last update: 2017-06-14 15:33    [W:3.036 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site