lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470
    Date
    Hi Lee,

    > Subject: Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470
    >
    > On Fri, 09 Jun 2017, Mani, Rajmohan wrote:
    >
    > > Hi Andy,
    > >
    > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote:
    > > > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani
    > > > <rajmohan.mani@intel.com> wrote:
    > > > > > The TPS68470 device is an advanced power management unit that
    > > > > > powers a Compact Camera Module (CCM), generates clocks for image
    > > > > > sensors, drives a dual LED for Flash and incorporates two LED
    > > > > > drivers for general purpose indicators.
    > > > > >
    > > > > > This patch adds support for TPS68470 mfd device.
    > > > >
    > > > > I dunno why you decide to send this out now, see my comments below.
    > > > >
    > > > > > +static int tps68470_chip_init(struct tps68470 *tps) {
    > > > > > + unsigned int version;
    > > > > > + int ret;
    > > > >
    > > > > > + /* FIXME: configure these dynamically */
    > > > >
    > > > > So, what prevents you to fix this?
    > > >
    > > > Nothing I suppose. They're however not needed right now and can be
    > > > implemented later on if they're ever needed.
    > > >
    > >
    > > Ack
    >
    > What does this mean? Is the plan to fix it or not? I don't want FIXMEs in the
    > code that a) can be fixed right away or b) might never be fixed.
    >

    I meant that this can be implemented later on, if there's a need.
    I will look into this and see how this can be fixed.

    Thanks
    Raj
    \
     
     \ /
      Last update: 2017-06-12 11:21    [W:2.150 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site