lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API
On Fri, Jun 02, 2017 at 11:08:48AM +0900, Byungchul Park wrote:
> On Fri, May 12, 2017 at 09:35:02AM +0900, Byungchul Park wrote:
> > Although llist provides proper APIs, they are not used. Make them used.
>
> +to axboe@kernel.dk
>
> I didn't know your e-mail address has been changed.
> Could you give your opinion about this patch?

I am sorry if I sent the patch to a wrong person. But otherwise, it
would be appriciated if you give your opinions on it, or let me know
the right person.

Thank you,
Byungchul

>
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > ---
> > drivers/md/bcache/closure.c | 17 +++--------------
> > 1 file changed, 3 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
> > index 864e673..1841d03 100644
> > --- a/drivers/md/bcache/closure.c
> > +++ b/drivers/md/bcache/closure.c
> > @@ -64,27 +64,16 @@ void closure_put(struct closure *cl)
> > void __closure_wake_up(struct closure_waitlist *wait_list)
> > {
> > struct llist_node *list;
> > - struct closure *cl;
> > + struct closure *cl, *t;
> > struct llist_node *reverse = NULL;
> >
> > list = llist_del_all(&wait_list->list);
> >
> > /* We first reverse the list to preserve FIFO ordering and fairness */
> > -
> > - while (list) {
> > - struct llist_node *t = list;
> > - list = llist_next(list);
> > -
> > - t->next = reverse;
> > - reverse = t;
> > - }
> > + reverse = llist_reverse_order(list);
> >
> > /* Then do the wakeups */
> > -
> > - while (reverse) {
> > - cl = container_of(reverse, struct closure, list);
> > - reverse = llist_next(reverse);
> > -
> > + llist_for_each_entry_safe(cl, t, reverse, list) {
> > closure_set_waiting(cl, 0);
> > closure_sub(cl, CLOSURE_WAITING + 1);
> > }
> > --
> > 1.9.1

\
 
 \ /
  Last update: 2017-06-13 02:39    [W:0.115 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site