lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: udf: allow implicit blocksize specification during mount
Date
Hi! I found that following UDF patch was included into linus tree:
https://patchwork.kernel.org/patch/9524557/

It is really a good improvement to recognize UDF file system which have
block size different from disk sector size and also different from 2048.

But should not detection on 4K native disks (4096/4096) try to also use
block size of 512 bytes? Because current loop is from logical sector
size to 4096.

Most of current hard drivers are 512/4096 (logical/physical), but there
are available USB based SATA controllers which via USB mass storage mode
reports logical block size value from physical block size of SATA disk.
So via such SATA controller computer see 4096/4096 disk and is unable to
detect UDF file system if was formatted with 512 block size.

Anyway, macro UDF_DEFAULT_BLOCKSIZE is not used in udf source code
anymore, so it can be deleted. I think its name was incorrect as default
block size for UDF should be logical block size of disk, not hardcoded
value 2048 which is logical block size for optical media.

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-06-12 23:25    [W:0.121 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site