lkml.org 
[lkml]   [2017]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] extcon: int3496: Switch to devm_acpi_dev_add_driver_gpios()
On 2017년 06월 11일 04:09, Andy Shevchenko wrote:
> Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify
> error path and fix potentially wrong assingment if ->probe() fails.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/extcon/extcon-intel-int3496.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index 9d17984bbbd4..d9f9afe45961 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -94,8 +94,7 @@ static int int3496_probe(struct platform_device *pdev)
> struct int3496_data *data;
> int ret;
>
> - ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev),
> - acpi_int3496_default_gpios);
> + ret = devm_acpi_dev_add_driver_gpios(dev, acpi_int3496_default_gpios);
> if (ret) {
> dev_err(dev, "can't add GPIO ACPI mapping\n");
> return ret;
> @@ -169,8 +168,6 @@ static int int3496_remove(struct platform_device *pdev)
> devm_free_irq(&pdev->dev, data->usb_id_irq, data);
> cancel_delayed_work_sync(&data->work);
>
> - acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev));
> -
> return 0;
> }
>
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics

\
 
 \ /
  Last update: 2017-06-12 03:02    [W:0.046 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site