lkml.org 
[lkml]   [2017]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm: Use vsnprintf extension %ph
On Wed, May 31, 2017 at 2:35 AM, Joe Perches <joe@perches.com> wrote:
> Using the extension saves a bit of code.

> + seq_printf(m, "faux/mst: %*ph\n", 2, buf);

> + seq_printf(m, "mst ctrl: %*ph\n", 1, buf);

> + seq_printf(m, "branch oui: %*phN devid: ", 3, buf);

All above may use shorter form, i.e.
"..., "%Xph", buf);", where X is a constant written explicitly inplace.

> + seq_printf(m, " revision: hw: %x.%x sw: %x.%x\n",
> + buf[0x9] >> 4, buf[0x9] & 0xf, buf[0xa], buf[0xb]);

Matter of taste, though buf[9], buf[10], buf[11] looks better to me :-)

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-06-12 01:55    [W:0.563 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site