lkml.org 
[lkml]   [2017]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased pages
    On Thu 2017-06-01 01:09:17, Darwin Dingel wrote:
    > Hi Pavel,
    >
    > Just a minor thing. Sorry about the late comment.
    >
    > On 01/06/17 08:59, Pavel Machek wrote:
    > > +
    > > + res = check_erased_page(chip, buf);
    > > + return res;
    > > + }
    >
    > Can we just remove 'res' and change this line to:
    > return check_erased_page(chip, buf);

    Well... I originally had a printk there, and yes, it can be
    simplified. I can roll v3, if required, but I'd leave it as is -- it
    is still convenient place to add debugging to.

    Best regards,
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-06-01 15:13    [W:3.835 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site