lkml.org 
[lkml]   [2017]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler
From
Date
On 01/06/2017 06:41, Christoph Hellwig wrote:
>> + case SAS_PROTOCOL_SSP:
>> + {
>> + unsigned char op = task->ssp_task.cmd->cmnd[0];
>> +
>> + if (op == READ_6 || op == WRITE_6 ||
>> + op == READ_10 || op == WRITE_10 ||
>> + op == READ_12 || op == WRITE_12 ||
>> + op == READ_16 || op == WRITE_16)
>> + return true;
>> + break;
>> + }
>
> Wee. why do you care? >

In the command completion code we need to check for abnormal completion
due to underflow, but ignore it when it occurs in some commands, like
inquiry. This is why we check for rw command - it is equivalent to !inquiry.

I'll see if we can change the check to explicitly ignore certain
commands which complete abnormally with underflow.

>What about 32-byte CDs or things like Write Same?
>

You're talking about VARIABLE_LENGTH_CMD (opcode 0x7f) for 32-byte CDs,
right?

I need to check on WRITE SAME.

> .
>

Thanks,
John


\
 
 \ /
  Last update: 2017-06-01 12:41    [W:0.539 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site