Messages in this thread | | | Date | Tue, 9 May 2017 10:46:18 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition |
| |
On Mon, May 08, 2017 at 10:00:37PM -0400, Harinath Nampally wrote: > This patch fixes below checkpatch.pl warning: > CHECK: struct mutex definition without comment > > Signed-off-by: Harinath Nampally <harinath922@gmail.com> > --- > drivers/staging/iio/meter/ade7753.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c > index b71fbd3..cffe6bf 100644 > --- a/drivers/staging/iio/meter/ade7753.c > +++ b/drivers/staging/iio/meter/ade7753.c > @@ -78,12 +78,13 @@ > /** > * struct ade7753_state - device instance specific data > * @us: actual spi_device > + * @buf_lock: mutex to protect tx and rx > * @tx: transmit buffer > * @rx: receive buffer > - * @buf_lock: mutex to protect tx and rx > **/ > struct ade7753_state { > struct spi_device *us; > + /* mutex to protect tx and rx */
Not aligned. We don't need two duplicate comments anyway.
> struct mutex buf_lock;
regards, dan carpenter
| |