Messages in this thread | | | From | Kees Cook <> | Date | Mon, 8 May 2017 15:28:42 -0700 | Subject | Re: [PATCH] x86/mm: Set __vmalloc_start_set in numa_32.c |
| |
On Mon, May 8, 2017 at 2:23 PM, Laura Abbott <labbott@redhat.com> wrote: > __vmalloc_start_set currently only gets set in initmem_init when > !CONFIG_NEED_MULTIPLE_NODES. This currently breaks detection of vmalloc > address with virt_addr_valid with CONFIG_NEED_MULTIPLE_NODES=y. > Set __vmalloc_start_set appropriately for that case as well. > > Fixes: dc16ecf7fd1f ("x86-32: use specific __vmalloc_start_set flag in __virt_addr_valid")q
Nit: trailing "q" typo
> Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks for tracking this down!
-Kees
> --- > arch/x86/mm/numa_32.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c > index 6b7ce62..aca6295 100644 > --- a/arch/x86/mm/numa_32.c > +++ b/arch/x86/mm/numa_32.c > @@ -100,5 +100,6 @@ void __init initmem_init(void) > printk(KERN_DEBUG "High memory starts at vaddr %08lx\n", > (ulong) pfn_to_kaddr(highstart_pfn)); > > + __vmalloc_start_set = true; > setup_bootmem_allocator(); > } > -- > 2.7.4 >
-- Kees Cook Pixel Security
| |