Messages in this thread | | | Date | Mon, 8 May 2017 23:06:02 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 0/3] led: ledtrig-transient: add support for hrtimer |
| |
On Sun 2017-04-30 14:36:58, David Lin wrote: > Hi, > > These patch series add the LED_BRIGHTNESS_FAST flag support for > ledtrig-transient to use hrtimer so that platforms with high-resolution timer > support can have better accuracy in the trigger duration timing. The need for > this support is driven by the fact that Android has removed the timed_ouput [1] > and is now using led-trigger for handling vibrator control which requires the > timer to be accurate up to a millisecond. However, this flag support would also > allow hrtimer to co-exist with the ktimer without causing warning to the > existing drivers [2].
Yes, and objection still stands: You are misusing LED subsystem for vibration motors. We already have support for haptic feedback in input subsystem.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |