Messages in this thread | | | Date | Mon, 8 May 2017 12:04:43 +0200 | From | Robert Richter <> | Subject | Re: [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74 |
| |
On 08.05.17 10:59:46, Robin Murphy wrote: > On 08/05/17 10:17, Linu Cherian wrote: > > This actually results in more lines of changes. If you think the below > > approach is still better, will post a V4 of this series with this change. > > Why not just do this?: > > static inline unsigned long page1_offset_adjust( > unsigned long off, struct arm_smmu_device *smmu) > { > if (off > SZ_64K && ARM_SMMU_PAGE0_REGS_ONLY(smmu)) > return (off - SZ_64K); > > return off; > } > > AFAICS that should be the least disruptive way to go about it.
Yeah, let's go with this.
Thanks Robin,
-Robert
| |