lkml.org 
[lkml]   [2017]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] char: random: casting prevents missing calculations
Date
Cast (long)jiffies and (long)state->last_time beacause
they tends to unsigned long. may cause a problem specially
when comparison happens (< 0).

Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
drivers/char/random.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 0ab0249..f685e78 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1012,7 +1012,7 @@ static void add_timer_randomness(struct timer_rand_state *state, unsigned num)

preempt_disable();

- sample.jiffies = jiffies;
+ sample.jiffies = (long)jiffies;
sample.cycles = random_get_entropy();
sample.num = num;
r = &input_pool;
@@ -1025,7 +1025,7 @@ static void add_timer_randomness(struct timer_rand_state *state, unsigned num)
*/

if (!state->dont_count_entropy) {
- delta = sample.jiffies - state->last_time;
+ delta = sample.jiffies - (long)state->last_time;
state->last_time = sample.jiffies;

delta2 = delta - state->last_delta;
--
2.7.4
\
 
 \ /
  Last update: 2017-05-08 00:11    [W:0.061 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site