Messages in this thread | | | Subject | Re: [PATCH] Staging: rtl8723bs: core: Fixed a brace coding style issue | From | Joe Perches <> | Date | Sat, 06 May 2017 05:14:27 -0700 |
| |
On Sat, 2017-05-06 at 14:00 +0200, Rene Hickersberger wrote: > Fixed a brace coding style issue. [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c [] > @@ -863,11 +863,10 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork) > auth = &psecuritypriv->authenticator_ie[0]; > psecuritypriv->authenticator_ie[0] = (unsigned char)psecnetwork->IELength; > > - if ((psecnetwork->IELength-12) < (256-1)) { > + if ((psecnetwork->IELength-12) < (256-1)) > memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], psecnetwork->IELength-12); > - } else { > + else > memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], (256-1)); > - }
Because the first 2 arguments are very long and identical, it's probably better to not use braces but use min() instead
memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], min(psecnetwork->IELength - 12, 256 - 1));
| |