Messages in this thread | | | Date | Fri, 5 May 2017 08:23:33 +0200 | From | Ingo Molnar <> | Subject | Re: [Patch v2] x86/build: require only gcc use -maccumulate-outgoing-args |
| |
* Nick Desaulniers <nick.desaulniers@gmail.com> wrote:
> Other compilers, like clang, treat unknown compiler flags as errors. > > Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com> > --- > arch/x86/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Makefile b/arch/x86/Makefile > index 4430dd489620..12757a252e6b 100644 > --- a/arch/x86/Makefile > +++ b/arch/x86/Makefile > @@ -179,7 +179,7 @@ ifdef CONFIG_JUMP_LABEL > endif > > ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1) > - KBUILD_CFLAGS += -maccumulate-outgoing-args > + KBUILD_CFLAGS += $(if $(filter gcc,$(cc-name)),-maccumulate-outgoing-args) > endif > > # Stackpointer is addressed different for 32 bit and 64 bit x86
The justification Josh gave for this pattern should be put into a comment and into the changelog as well.
Thanks,
Ingo
| |