lkml.org 
[lkml]   [2017]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 8/9] clocksource/drivers/fttmr010: Drop unnecessary static
Date
Drop static on a local variable, when the variable is initialized before
any use, on every possible execution path through the function. The static
has no benefit, and dropping it reduces the code size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
T x@p;
... when != x
when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
text data bss dec hex filename
1777 4352 20 6149 1805 drivers/clocksource/timer-fttmr010.o

after:
text data bss dec hex filename
1770 4352 12 6134 17f6 drivers/clocksource/timer-fttmr010.o

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
drivers/clocksource/timer-fttmr010.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/timer-fttmr010.c
index b4a6f1e..055c65e 100644
--- a/drivers/clocksource/timer-fttmr010.c
+++ b/drivers/clocksource/timer-fttmr010.c
@@ -263,7 +263,7 @@ static int __init fttmr010_timer_of_init(struct device_node *np)

static int __init gemini_timer_of_init(struct device_node *np)
{
- static struct regmap *map;
+ struct regmap *map;
int ret;
u32 val;

\
 
 \ /
  Last update: 2017-05-04 22:37    [W:0.151 / U:2.804 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site