lkml.org 
[lkml]   [2017]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 3/6] cxgb4vf: Adjust five checks for null pointers
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 4 May 2017 21:20:25 +0200
    MIME-Version: 1.0
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: 8bit

    The script “checkpatch.pl” pointed information out like the following.

    Comparison to NULL could be written !…

    Thus fix the affected source code places.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
    index 9c2690aeb32b..682e844c5a7d 100644
    --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
    +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
    @@ -491,7 +491,7 @@ static int fwevtq_handler(struct sge_rspq *rspq, const __be64 *rsp,
    break;
    }
    tq = s->egr_map[eq_idx];
    - if (unlikely(tq == NULL)) {
    + if (unlikely(!tq)) {
    dev_err(adapter->pdev_dev,
    "Egress Update QID %d TXQ=NULL\n", qid);
    break;
    @@ -2939,7 +2939,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
    */
    netdev = alloc_etherdev_mq(sizeof(struct port_info),
    MAX_PORT_QSETS);
    - if (netdev == NULL) {
    + if (!netdev) {
    t4vf_free_vi(adapter, viid);
    err = -ENOMEM;
    goto err_free_dev;
    @@ -3053,7 +3053,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
    for_each_port(adapter, pidx) {
    struct port_info *pi = netdev_priv(adapter->port[pidx]);
    netdev = adapter->port[pidx];
    - if (netdev == NULL)
    + if (!netdev)
    continue;

    netif_set_real_num_tx_queues(netdev, pi->nqsets);
    @@ -3120,7 +3120,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
    err_free_dev:
    for_each_port(adapter, pidx) {
    netdev = adapter->port[pidx];
    - if (netdev == NULL)
    + if (!netdev)
    continue;
    pi = netdev_priv(netdev);
    t4vf_free_vi(adapter, pi->viid);
    @@ -3197,7 +3197,7 @@ static void cxgb4vf_pci_remove(struct pci_dev *pdev)
    struct net_device *netdev = adapter->port[pidx];
    struct port_info *pi;

    - if (netdev == NULL)
    + if (!netdev)
    continue;

    pi = netdev_priv(netdev);
    --
    2.12.2
    \
     
     \ /
      Last update: 2017-05-04 22:34    [W:3.272 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site