Messages in this thread | | | Date | Thu, 4 May 2017 16:36:22 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v5 06/32] x86/mm: Add Secure Memory Encryption (SME) support |
| |
On Thu, May 04, 2017 at 09:24:11AM -0500, Tom Lendacky wrote: > I did this so that an the include order wouldn't cause issues (including > asm/mem_encrypt.h followed by later by a linux/mem_encrypt.h include). > I can make this a bit clearer by having separate #defines for each > thing, e.g.: > > #ifndef sme_me_mask > #define sme_me_mask 0UL > #endif > > #ifndef sme_active > #define sme_active sme_active > static inline ... > #endif > > Is that better/clearer?
I guess but where do we have to include both the asm/ and the linux/ version?
IOW, can we avoid these issues altogether by partitioning symbol declarations differently among the headers?
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |