Messages in this thread | | | Date | Wed, 31 May 2017 12:52:09 -0500 | From | Rob Herring <> | Subject | Re: [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 |
| |
On Thu, May 25, 2017 at 11:49:16AM +1200, Chris Packham wrote: > The mchp23lcv1024 is similar to the mchp23k256, the differences (from a > software point of view) are the capacity of the chip and the size of the > addresses used. > > There is no way to detect the specific chip so we must be told via a > Device Tree or default to mchp23k256 when device tree is not used. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- > Changes in v2: > - fix formatting in switch statement > - add support for 24-bit addressing > Changes in v3: > - None > Changes in v4: > - reword commit message (thanks Andrew) > - introduce mchp23_caps struct (thanks Boris) > > .../bindings/mtd/microchip,mchp23k256.txt | 2 +-
I'd rather see a single binding patch than split like this, but it's fine.
Acked-by: Rob Herring <robh@kernel.org>
> drivers/mtd/devices/mchp23k256.c | 66 ++++++++++++++++++---- > 2 files changed, 57 insertions(+), 11 deletions(-)
| |