lkml.org 
[lkml]   [2017]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
    On Tue, May 30, 2017 at 11:00:04AM +0100, David Howells wrote:
    > This isn't going to work. You've effectively changed the types of the fields
    > in the UUID struct from BE to CPU-endian, but you're still calling
    > generate_random_uuid(), which produces a BE UUID. You need to leave the
    > struct members as __beXX or stop using the core UUID routines.
    >
    > Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
    > afs_uuid. You can then leave the (un)marshalling code alone.

    That's one option. The other option would be to revert

    "afs: Use core kernel UUID generation", as that also changed the
    v1 UUID to a v4 uuid. Does the afs protocol require a v1 uuid
    or does it just use the formwat on the wire?

    \
     
     \ /
      Last update: 2017-05-31 11:44    [W:6.818 / U:1.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site