Messages in this thread | | | Subject | Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. | From | Archit Taneja <> | Date | Wed, 31 May 2017 14:05:46 +0530 |
| |
On 05/31/2017 01:37 PM, Boris Brezillon wrote: > Hi Archit, > > Le Wed, 31 May 2017 13:31:16 +0530, > Archit Taneja <architt@codeaurora.org> a écrit : > >> Hi Boris, >> >> On 05/31/2017 11:56 AM, Boris Brezillon wrote: >>> Hi Philippe, >>> >>> Le Tue, 30 May 2017 16:55:42 +0000, >>> Philippe CORNU <philippe.cornu@st.com> a écrit : >>> >>>> Hi Eric, >>>> >>>> I took your patch for the panel-bridge and it works perfectly in both >>>> DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi), bravo :-) >>> >>> I still don't understand how it can work without a call to >>> drm_bridge_attach() (which is used to link the RGB encoder to the DPI >>> connector). I'm probably missing something obvious. Maybe someone can >>> point it out :-). >> >> I think the expectation is that there will be a follow-up patch that >> would add bridge support. Philippe had posted a patch for adding bridges >> to ltdc before: >> >> https://patchwork.kernel.org/patch/9724835/ >> >> He can now redo his patch over Eric's panel-bridge patch-set. > > But by doing that you're breaking bisectability, or is it working when > applying only Eric's patchset? > > If applying this patch breaks the driver, why not applying it after > bridge support has been added to this driver?
Yeah, it would break the driver. Philippe can create a patch that adds bridge support using the panel-bridge glue layer using Eric's patch as a reference. In the end, there should only be a single patch.
Thanks, Archit
> > Regards, > > Boris >
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |