Messages in this thread | | | Date | Wed, 31 May 2017 10:35:23 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH 4/7] driver core: fix automatic pinctrl management |
| |
On Wed, May 31, 2017 at 02:39:28AM +0200, Linus Walleij wrote: > On Tue, May 30, 2017 at 6:25 PM, Johan Hovold <johan@kernel.org> wrote: > > > Commit ab78029ecc34 ("drivers/pinctrl: grab default handles from device > > core") added automatic pin-control management to driver core by looking > > up and setting any default pinctrl state found in device tree while a > > device is being probed. > > Actually we do not just support device tree, but also passing pin control > states from board files. It is handled by the core all the same. > So it's not a device tree thing. > > One of those days we will have ACPI passing state tables too... > > But I understand what you mean.
Yes, I could have mentioned board files, but this problem only applies to device-tree descriptions (for the time being at least).
> > Fix this by checking the new of_node_reused flag and skipping automatic > > pinctrl configuration during probe if set. > > Seems like a solid idea. I hope we don't need another quirk for ACPI.
We should be able to just generalise and rename the flag (or add a second one) if it turns out ACPI needs this too.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, Johan
| |