Messages in this thread | | | Date | Wed, 31 May 2017 20:09:08 -0700 | From | Eduardo Valentin <> | Subject | Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP |
| |
On Wed, May 31, 2017 at 03:55:44PM -0400, Jon Mason wrote: > ARCH_BCM_IPROC includes support for many SoCs, not all of which have the > same thermal hardware interface as the Northstar/Northstar Plus SoCs. > This is not a major issue, as this driver will only be probed if the > relevant device tree entry is present. However, it will result in a > slightly larger than necessary kernel. By limiting the driver to only > work on the NS/NSP SoCs, we can avoid the issue. > > Suggested-by: Scott Branden <scott.branden@broadcom.com> > Signed-off-by: Jon Mason <jon.mason@broadcom.com>
Should this commit message include a Fixes: tag?
Maybe Fixes: a94cb7e ("thermal: broadcom: add Northstar thermal driver")
> --- > drivers/thermal/broadcom/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig > index 42c098e86f84..c729dad2348c 100644 > --- a/drivers/thermal/broadcom/Kconfig > +++ b/drivers/thermal/broadcom/Kconfig > @@ -8,8 +8,8 @@ config BCM2835_THERMAL > > config BCM_NS_THERMAL > tristate "Northstar thermal driver" > - depends on ARCH_BCM_IPROC || COMPILE_TEST > - default y if ARCH_BCM_IPROC > + depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST > + default y if ARCH_BCM_NSP || ARCH_BCM_5301X > help > Support for the Northstar and Northstar Plus family of SoCs (e.g. > BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device > -- > 2.7.4 > [unhandled content-type:application/pgp-signature] | |