lkml.org 
[lkml]   [2017]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] arm64:vdso: Remove ISB from gettimeofday.
Date
ISB is normally required before mrs CNTVCT if we want the
mrs to completed after the loads. In this case it is not.
As we are taking the difference and if that difference
was going to be negative, we just use the last counter value
instead.

Signed-off-by: Andrew Pinski <apinski@cavium.com>
---
arch/arm64/kernel/vdso/gettimeofday.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/vdso/gettimeofday.c b/arch/arm64/kernel/vdso/gettimeofday.c
index 1293786..49edd35 100644
--- a/arch/arm64/kernel/vdso/gettimeofday.c
+++ b/arch/arm64/kernel/vdso/gettimeofday.c
@@ -117,10 +117,20 @@ static notrace u64 get_clock_shifted_nsec(u64 cycle_last, u64 mult)
u64 res;

/* Read the virtual counter. */
- isb();
+ /*
+ * This normally requires an ISB but since we know the
+ * read of the last cycle will always be after the
+ * read of the values are valid word.
+ */
asm volatile("mrs %0, cntvct_el0" : "=r" (res) :: "memory");

- res = res - cycle_last;
+ /*
+ * If the current cycle is greater than the last,
+ * then get the difference.
+ */
+ if (res > cycle_last)
+ res = res - cycle_last;
+
/* We can only guarantee 56 bits of precision. */
res &= ~(0xff00ull<<48);
return res * mult;
--
2.7.4
\
 
 \ /
  Last update: 2017-05-31 02:41    [W:0.135 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site