lkml.org 
[lkml]   [2017]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tpm, tpmrm: Mark tpmrm_write as static
On Thu, May 25, 2017 at 07:43:05AM +0200, Peter Huewe wrote:
> sparse complains that tpmrm_write can be made static, and since it is
> right we make it static.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> ---
> drivers/char/tpm/tpmrm-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpmrm-dev.c b/drivers/char/tpm/tpmrm-dev.c
> index c636e7f..1a0e97a 100644
> --- a/drivers/char/tpm/tpmrm-dev.c
> +++ b/drivers/char/tpm/tpmrm-dev.c
> @@ -45,7 +45,7 @@ static int tpmrm_release(struct inode *inode, struct file *file)
> return 0;
> }
>
> -ssize_t tpmrm_write(struct file *file, const char __user *buf,
> +static ssize_t tpmrm_write(struct file *file, const char __user *buf,
> size_t size, loff_t *off)
> {
> struct file_priv *fpriv = file->private_data;
> --
> 2.10.2
>

\
 
 \ /
  Last update: 2017-05-30 06:46    [W:0.040 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site