Messages in this thread | | | From | Gregory CLEMENT <> | Subject | Re: [PATCH 1/2] gpio: mvebu: fix blink counter register selection | Date | Tue, 30 May 2017 15:01:33 +0200 |
| |
Hi Richard,
On mar., mai 30 2017, Richard Genoud <richard.genoud@gmail.com> wrote:
> The blink counter A was always selected because 0 was forced in the > blink select counter register. > The variable 'set' was obviously there to be used as the register value, > selecting the B counter when id==1 and A counter when id==0. > > Tested on clearfog-pro (Marvell 88F6828) > > Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Looks good for me:
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
I thinks this one should go to v4.12-rc as it is a fix.
As I modified the same part of the code in my series, I think I will have to rebase my series on top of this patch as soon as Linus Walleij will have accepted it.
Thanks,
Gregory
> --- > drivers/gpio/gpio-mvebu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c > index 19a92efabbef..cdef2c78cb3b 100644 > --- a/drivers/gpio/gpio-mvebu.c > +++ b/drivers/gpio/gpio-mvebu.c > @@ -747,7 +747,7 @@ static int mvebu_pwm_probe(struct platform_device *pdev, > set = U32_MAX; > else > return -EINVAL; > - writel_relaxed(0, mvebu_gpioreg_blink_counter_select(mvchip)); > + writel_relaxed(set, mvebu_gpioreg_blink_counter_select(mvchip)); > > mvpwm = devm_kzalloc(dev, sizeof(struct mvebu_pwm), GFP_KERNEL); > if (!mvpwm)
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
| |