Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" | Date | Tue, 30 May 2017 11:00:04 +0100 |
| |
Christoph Hellwig <hch@lst.de> wrote:
> This reverts commit ff548773106ec7f8031bc6172e0234bd2a02c19c. > > The V1 uuid intrepreatation in struct form isn't really useful to the > rest of the kernel, and not really compatible to it either, so move it > back to AFS instead of polluting the global uuid.h.
This isn't going to work. You've effectively changed the types of the fields in the UUID struct from BE to CPU-endian, but you're still calling generate_random_uuid(), which produces a BE UUID. You need to leave the struct members as __beXX or stop using the core UUID routines.
Just move the struct uuid_v1 as-is to the afs headers and rename it to struct afs_uuid. You can then leave the (un)marshalling code alone.
David
| |