lkml.org 
[lkml]   [2017]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
    Date
    Christoph Hellwig <hch@lst.de> wrote:

    > This reverts commit ff548773106ec7f8031bc6172e0234bd2a02c19c.
    >
    > The V1 uuid intrepreatation in struct form isn't really useful to the
    > rest of the kernel, and not really compatible to it either, so move it
    > back to AFS instead of polluting the global uuid.h.

    This isn't going to work. You've effectively changed the types of the fields
    in the UUID struct from BE to CPU-endian, but you're still calling
    generate_random_uuid(), which produces a BE UUID. You need to leave the
    struct members as __beXX or stop using the core UUID routines.

    Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
    afs_uuid. You can then leave the (un)marshalling code alone.

    David

    \
     
     \ /
      Last update: 2017-05-30 12:00    [W:4.060 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site